[PATCH 1/2] winegstreamer: Remove redundant null check before g_error_free.
Andrew Eikum
aeikum at codeweavers.com
Fri Nov 18 09:18:56 CST 2016
Signed-off-by: Andrew Eikum <aeikum at codeweavers.com>
On Thu, Nov 17, 2016 at 08:46:37AM -0700, Alex Henrie wrote:
> Cc: Andrew Eikum <aeikum at codeweavers.com>
>
> The first thing that g_error_free does is check the pointer:
> https://github.com/GNOME/glib/blob/master/glib/gerror.c#L480
>
> Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
> ---
> dlls/winegstreamer/gstdemux.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/dlls/winegstreamer/gstdemux.c b/dlls/winegstreamer/gstdemux.c
> index e954e61..67690a3 100644
> --- a/dlls/winegstreamer/gstdemux.c
> +++ b/dlls/winegstreamer/gstdemux.c
> @@ -1088,8 +1088,7 @@ static GstBusSyncReply watch_bus(GstBus *bus, GstMessage *msg, gpointer data)
> WARN("%s: %s\n", GST_OBJECT_NAME(msg->src), err->message);
> WARN("%s\n", dbg_info);
> }
> - if (err)
> - g_error_free(err);
> + g_error_free(err);
> g_free(dbg_info);
> return GST_BUS_DROP;
> }
> --
> 2.10.2
>
More information about the wine-patches
mailing list