[PATCH] hidclass.sys: Use IoSetCompletionRoutine

Sebastian Lackner sebastian at fds-team.de
Tue Oct 18 10:40:26 CDT 2016


On 18.10.2016 17:07, Aric Stewart wrote:
> Signed-off-by: Aric Stewart <aric at codeweavers.com>
> ---
>  dlls/hidclass.sys/device.c | 20 +++++++-------------
>  dlls/hidclass.sys/main.c   | 13 +++++--------
>  dlls/hidclass.sys/pnp.c    | 10 +++++-----
>  3 files changed, 17 insertions(+), 26 deletions(-)

Thanks! While you are just at it, could you please also check the two
occurances of "if (irp->IoStatus.u.Status == STATUS_PENDING)"? They
look wrong to me, the correct way would be to check the return value
of IoCallDriver. Also, it looks like call_minidriver is leaking "buffer".

Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>




More information about the wine-patches mailing list