[PATCH] explorer: check icon for NULL (Coverity)

Marcus Meissner marcus at jet.franken.de
Wed Oct 19 02:22:48 CDT 2016


1373719 Dereference after null check

Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
---
 programs/explorer/systray.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/programs/explorer/systray.c b/programs/explorer/systray.c
index b3c192a..2c49082 100644
--- a/programs/explorer/systray.c
+++ b/programs/explorer/systray.c
@@ -588,8 +588,11 @@ static BOOL handle_incoming(HWND hwndSource, COPYDATASTRUCT *cds)
         if (icon) ret = modify_icon( icon, &nid );
         break;
     case NIM_SETVERSION:
-        icon->version = nid.u.uVersion;
-        ret = TRUE;
+        if (icon) 
+        {
+            icon->version = nid.u.uVersion;
+            ret = TRUE;
+        }
         break;
     default:
         WINE_FIXME("unhandled tray message: %ld\n", cds->dwData);
-- 
2.10.1




More information about the wine-patches mailing list