oledlg: Properly use SUCCEEDED macro to check HRESULT.

Sebastian Lackner sebastian at fds-team.de
Tue Sep 13 02:05:19 CDT 2016


Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>
---

.../dlls/oledlg/insobjdlg.c:483:25: warning: Comparing 'int' against 'HRESULT' (aka 'int') [wine-hresult-check]
      if (ERROR_SUCCESS == (hres = GetClassFile(wcsFile, &pdlgInfo->lpOleUIInsertObject->clsid)))
                        ^

 dlls/oledlg/insobjdlg.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/oledlg/insobjdlg.c b/dlls/oledlg/insobjdlg.c
index 159f12b..7cbea4e 100644
--- a/dlls/oledlg/insobjdlg.c
+++ b/dlls/oledlg/insobjdlg.c
@@ -480,7 +480,7 @@ static BOOL UIINSERTOBJECTDLG_OnOpen(InsertObjectDlgInfo* pdlgInfo)
           WideCharToMultiByte(CP_ACP, 0, wcsFile, -1,
               pdlgInfo->lpOleUIInsertObject->lpszFile, pdlgInfo->lpOleUIInsertObject->cchFile, NULL, NULL);
 
-      if (ERROR_SUCCESS == (hres = GetClassFile(wcsFile, &pdlgInfo->lpOleUIInsertObject->clsid)))
+      if (SUCCEEDED(hres = GetClassFile(wcsFile, &pdlgInfo->lpOleUIInsertObject->clsid)))
       {
          if (pdlgInfo->lpOleUIInsertObject->dwFlags & IOF_CREATEFILEOBJECT)
          {
-- 
2.9.0



More information about the wine-patches mailing list