[Tools] testbot/WineRunTask: Improve some error messages.

Francois Gouget fgouget at codeweavers.com
Tue Apr 18 05:16:48 CDT 2017


These error messages are shown separately from the place where the error
is so it is important to provide context.
Also always start with the dll and test unit for consistency.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineRunTask.pl | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl
index cb127772..8b9afabf 100755
--- a/testbot/bin/WineRunTask.pl
+++ b/testbot/bin/WineRunTask.pl
@@ -478,7 +478,7 @@ if ($TA->GetFile($RptFileName, $FullLogFileName))
         my ($Dll, $Unit) = ($1, $2);
         if ($CurrentDll ne "")
         {
-          LogTaskError("The done line is missing for $CurrentDll:$CurrentUnit\n");
+          LogTaskError("$CurrentDll:$CurrentUnit has no done line\n");
           $LogFailures++;
         }
         ($CurrentDll, $CurrentUnit) = ($Dll, $Unit);
@@ -549,7 +549,7 @@ if ($TA->GetFile($RptFileName, $FullLogFileName))
           $CurrentIsPolluted = 1;
           if ($IsWineTest and ($Todo or $Failures))
           {
-            LogTaskError("Found a misplaced '$Unit' test summary line.\n");
+            LogTaskError("$CurrentDll:$CurrentUnit contains a misplaced test summary line for $Unit\n");
             $LogFailures++;
           }
         }
@@ -560,7 +560,7 @@ if ($TA->GetFile($RptFileName, $FullLogFileName))
 
         if ($IsWineTest and ($Dll ne $CurrentDll or $Unit ne $CurrentUnit))
         {
-          LogTaskError("The start line is missing for $Dll:$Unit\n");
+          LogTaskError("$Dll:$Unit had no start line\n");
           $LogFailures++;
           $CurrentIsPolluted = 1;
         }
-- 
2.11.0



More information about the wine-patches mailing list