[PATCH] secur32: Add support for SECPKG_ATTR_KEY_INFO.
sagawa.aki at gmail.com
Tue Apr 25 08:36:27 CDT 2017
On Mon, 24 Apr 2017 17:31:44 +0200, Jacek Caban wrote:
> From: Akihiro Sagawa <sagawa.aki at gmail.com>
> Signed-off-by: Akihiro Sagawa <sagawa.aki at gmail.com>
> Signed-off-by: Jacek Caban <jacek at codeweavers.com>
> I simplified get_alg_name. Although in this version ALG_ID was used as a
> key, comparison function was assuming full struct and it worked only
> because its layout allowed it. Anyway, I think that avoiding bsearch is
> even better. Keeping CALG_* sorted is non-trivial and we don't really
> need to optimize it (and I'm not sure bsearch is faster in this case
> dlls/secur32/schannel.c | 53 ++++++++++++++++++++++++++++++++++++++++++
> dlls/secur32/schannel_gnutls.c | 21 +++++++++++++++++
> dlls/secur32/schannel_macosx.c | 6 +++++
> dlls/secur32/secur32_priv.h | 1 +
> dlls/secur32/tests/schannel.c | 2 +-
> 5 files changed, 82 insertions(+), 1 deletion(-)
Thanks for reviewing and improving. It looks good to me.
Using bsearch() is slightly overdone for ALG_ID list indeed.
More information about the wine-patches