tools/wineinstall: fix shellcheck issues

Austin English austinenglish at gmail.com
Fri Feb 24 12:26:21 CST 2017


austin at austin2:~/wine-git$ shellcheck tools/wineinstall

In tools/wineinstall line 33:
    echo -n "$1"
         ^-- SC2039: In POSIX sh, echo flags are undefined.


In tools/wineinstall line 34:
    read ANSWER
    ^-- SC2162: read without -r will mangle backslashes.


In tools/wineinstall line 73:
if [ -x `which rpm 2>/dev/null` ]; then
        ^-- SC2046: Quote this to prevent word splitting.
        ^-- SC2006: Use $(..) instead of legacy `..`.


In tools/wineinstall line 74:
    if [ -n "`rpm -qi wine 2>/dev/null|grep "^Name"`" ]; then
             ^-- SC2006: Use $(..) instead of legacy `..`.


In tools/wineinstall line 82:
        if [ $RET -eq 0 ]; then
             ^-- SC2086: Double quote to prevent globbing and word splitting.


In tools/wineinstall line 99:
if [ -x `which wine 2>/dev/null` ] && [ -n "`wine --version 2>/dev/null`" ]
        ^-- SC2046: Quote this to prevent word splitting.
        ^-- SC2006: Use $(..) instead of legacy `..`.
                                            ^-- SC2006: Use $(..)
instead of legacy `..`.


-- 
-Austin
GPG: 14FB D7EA A041 937B
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-tools-wineinstall-fix-shellcheck-issues.patch
Type: text/x-patch
Size: 1899 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20170224/0821df91/attachment.bin>


More information about the wine-patches mailing list