[PATCH 3/4] ddraw: Don't write out if a ddraw4 surface of size 0 is requested.
Alex Henrie
alexhenrie24 at gmail.com
Fri Jan 6 01:07:29 CST 2017
Signed-off-by: Alex Henrie <alexhenrie24 at gmail.com>
---
dlls/ddraw/ddraw.c | 3 ---
dlls/ddraw/tests/ddraw4.c | 4 ++++
2 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/dlls/ddraw/ddraw.c b/dlls/ddraw/ddraw.c
index e5eed34f7c..e761032a56 100644
--- a/dlls/ddraw/ddraw.c
+++ b/dlls/ddraw/ddraw.c
@@ -2867,10 +2867,7 @@ static HRESULT WINAPI ddraw4_CreateSurface(IDirectDraw4 *iface,
hr = ddraw_surface_create(ddraw, surface_desc, &impl, outer_unknown, 4);
wined3d_mutex_unlock();
if (FAILED(hr))
- {
- *surface = NULL;
return hr;
- }
*surface = &impl->IDirectDrawSurface4_iface;
IDirectDraw4_AddRef(iface);
diff --git a/dlls/ddraw/tests/ddraw4.c b/dlls/ddraw/tests/ddraw4.c
index b74b7541f9..cba3b14ee4 100644
--- a/dlls/ddraw/tests/ddraw4.c
+++ b/dlls/ddraw/tests/ddraw4.c
@@ -2223,6 +2223,10 @@ static void test_surface_qi(void)
surface_desc.dwSize = sizeof(surface_desc);
surface_desc.dwFlags = DDSD_CAPS | DDSD_WIDTH | DDSD_HEIGHT;
surface_desc.ddsCaps.dwCaps = DDSCAPS_TEXTURE;
+
+ hr = IDirectDraw4_CreateSurface(ddraw, &surface_desc, (IDirectDrawSurface4 **)0xdeadbeef, NULL);
+ ok(hr == E_INVALIDARG, "Got unexpected hr %#x.\n", hr);
+
surface_desc.dwWidth = 512;
surface_desc.dwHeight = 512;
hr = IDirectDraw4_CreateSurface(ddraw, &surface_desc, &surface, NULL);
--
2.11.0
More information about the wine-patches
mailing list