[PATCH] shell32: fixed CharLowerBuffA size

Marcus Meissner marcus at jet.franken.de
Fri Jan 13 16:42:51 CST 2017


-1 is definitely invalid here (DWORD charactercount) ... so use
strlen()

Signed-off-by: Marcus Meissner <marcus at jet.franken.de>
---
 dlls/shell32/tests/shelllink.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/shell32/tests/shelllink.c b/dlls/shell32/tests/shelllink.c
index b789db4a18..fdf2b14702 100644
--- a/dlls/shell32/tests/shelllink.c
+++ b/dlls/shell32/tests/shelllink.c
@@ -1276,7 +1276,7 @@ todo_wine {
     index = 5000;
     strcpy(pathA, "user32.dll");
     hicon = ExtractAssociatedIconA(NULL, pathA, &index);
-    CharLowerBuffA(pathA, -1);
+    CharLowerBuffA(pathA, strlen(pathA));
 todo_wine {
     ok(hicon != NULL, "Got icon %p\n", hicon);
     ok(!!strstr(pathA, "shell32.dll"), "Unexpected path %s\n", pathA);
@@ -1288,7 +1288,7 @@ todo_wine {
     index = 0xcaca;
     strcpy(pathA, "dummy.exe");
     hicon = ExtractAssociatedIconA(NULL, pathA, &index);
-    CharLowerBuffA(pathA, -1);
+    CharLowerBuffA(pathA, strlen(pathA));
 todo_wine {
     ok(hicon != NULL, "Got icon %p\n", hicon);
     ok(!!strstr(pathA, "shell32.dll"), "Unexpected path %s\n", pathA);
-- 
2.11.0




More information about the wine-patches mailing list