rpcrt4: Avoid potential overflow in rpcrt4_protseq_ncacn_np_open_endpoint.

Gerald Pfeifer gerald at pfeifer.com
Sat Jan 21 09:32:22 CST 2017


GCC 7 is starting to diagnose a larger categories of overflows
in sprintf and friends; this is one of the few remaining examples
in Wine.  

Since we are using snprintf we aren't exposed in terms of a real
security issue (good!), but still; and since it's that easy to
avoid.

Gerald

Signed-off-by: Gerald Pfeifer <gerald at pfeifer.com>
---
 dlls/rpcrt4/rpc_transport.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/rpcrt4/rpc_transport.c b/dlls/rpcrt4/rpc_transport.c
index 2537a3fd03..fb3edb49b0 100644
--- a/dlls/rpcrt4/rpc_transport.c
+++ b/dlls/rpcrt4/rpc_transport.c
@@ -346,7 +346,7 @@ static RPC_STATUS rpcrt4_protseq_ncacn_np_open_endpoint(RpcServerProtseq *protse
   RPC_STATUS r;
   LPSTR pname;
   RpcConnection *Connection;
-  char generated_endpoint[21];
+  char generated_endpoint[26];
 
   if (!endpoint)
   {
-- 
2.11.0



More information about the wine-patches mailing list