[PATCH 3/4] msi: Don't increment the refcount when creating dialogs.
Zebediah Figura
z.figura12 at gmail.com
Mon Jul 3 00:34:54 CDT 2017
We should only ever have one dialog anyway, and this is destroyed
when we close the package.
Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
dlls/msi/dialog.c | 2 --
dlls/msi/tests/package.c | 2 +-
2 files changed, 1 insertion(+), 3 deletions(-)
diff --git a/dlls/msi/dialog.c b/dlls/msi/dialog.c
index 93a3bad..a1e94b1 100644
--- a/dlls/msi/dialog.c
+++ b/dlls/msi/dialog.c
@@ -3918,7 +3918,6 @@ static msi_dialog *dialog_create( MSIPACKAGE *package, const WCHAR *name, msi_di
return NULL;
strcpyW( dialog->name, name );
dialog->parent = parent;
- msiobj_addref( &package->hdr );
dialog->package = package;
dialog->event_handler = event_handler;
dialog->finished = 0;
@@ -3929,7 +3928,6 @@ static msi_dialog *dialog_create( MSIPACKAGE *package, const WCHAR *name, msi_di
rec = msi_get_dialog_record( dialog );
if( !rec )
{
- msiobj_release( &package->hdr );
msi_free( dialog );
return NULL;
}
diff --git a/dlls/msi/tests/package.c b/dlls/msi/tests/package.c
index 93cc5df..f25c617 100644
--- a/dlls/msi/tests/package.c
+++ b/dlls/msi/tests/package.c
@@ -9528,7 +9528,7 @@ static void test_externalui_message(void)
ok_sequence(doaction_dialog_error_sequence, "MsiDoAction(\"error\")", FALSE);
MsiCloseHandle(hpkg);
- ok_sequence(closehandle_sequence, "MsiCloseHandle()", TRUE);
+ ok_sequence(closehandle_sequence, "MsiCloseHandle()", FALSE);
CoUninitialize();
DeleteFileA(msifile);
--
2.7.4
More information about the wine-patches
mailing list