winhttp/tests: Make notification tests more strict.

Jacek Caban jacek at codeweavers.com
Tue Jul 11 06:24:09 CDT 2017


Current way of 'skip' boolean value that allows any number of any
notification before marked one is pretty badly broken. A good example is
test_async, which uses that for WINHTTP_CALLBACK_STATUS_RESOLVING_NAME.
On modern Windows, it's never called in those tests (and actually, it
shouldn't be; it was called on old versions which had worse persistent
connection support, but even there it could or could not be called,
dependent on how buffering happens to work work given connection), so
all notification checks are skipped. Other tests have similar problems.

While changing that, I also changed tests to use /tests/* paths, which
are hosted in a way that makes them more predictable. With this patch,
only explicitly selected notifications may be skipped and Wine bugs are
explicit and have corresponding todo_wines.

Signed-off-by: Jacek Caban <jacek at codeweavers.com>
---
 dlls/winhttp/tests/notification.c | 185
++++++++++++++++++--------------------
 1 file changed, 87 insertions(+), 98 deletions(-)


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-winhttp-tests-Make-notification-tests-more-strict.diff
Type: text/x-patch
Size: 19570 bytes
Desc: not available
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20170711/21cc63b7/attachment.bin>


More information about the wine-patches mailing list