[PATCH 1/7] wined3d: Make a FIXME in cpu_blitter_clear() slightly more accurate.

Henri Verbeet hverbeet at codeweavers.com
Mon Jul 17 07:01:36 CDT 2017


The issue isn't so much stencil clears as clearing either depth or stencil on
formats that contain both.

Signed-off-by: Henri Verbeet <hverbeet at codeweavers.com>
---
 dlls/wined3d/surface.c | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/dlls/wined3d/surface.c b/dlls/wined3d/surface.c
index c1bb53e..c914e8d 100644
--- a/dlls/wined3d/surface.c
+++ b/dlls/wined3d/surface.c
@@ -3499,12 +3499,15 @@ static void cpu_blitter_clear(struct wined3d_blitter *blitter, struct wined3d_de
             }
         }
 
-        if ((flags & WINED3DCLEAR_ZBUFFER) && (view = fb->depth_stencil))
+        if ((flags & (WINED3DCLEAR_ZBUFFER | WINED3DCLEAR_STENCIL)) && (view = fb->depth_stencil))
+        {
+            if ((view->format->depth_size && !(flags & WINED3DCLEAR_ZBUFFER))
+                    || (view->format->stencil_size && !(flags & WINED3DCLEAR_STENCIL)))
+                FIXME("Clearing %#x on %s.\n", flags, debug_d3dformat(view->format->id));
+
             surface_cpu_blt_colour_fill(view, &box, &c);
+        }
     }
-
-    if (flags & ~(WINED3DCLEAR_TARGET | WINED3DCLEAR_ZBUFFER))
-        FIXME("flags %#x not implemented.\n", flags);
 }
 
 static void cpu_blitter_blit(struct wined3d_blitter *blitter, enum wined3d_blit_op op,
-- 
2.1.4




More information about the wine-patches mailing list