[PATCH 3/6] msi: Don't set _BrowseProperty.

Zebediah Figura z.figura12 at gmail.com
Thu Jul 20 23:43:12 CDT 2017


This is a revert of 166a7e993cb0033fac7ec2712c346558fb7bd100,
which was introduced to fix bug #28219. _BrowseProperty is not set
by Windows, but should rather be set by the program in question, and
was not being set due to a bug in Wine, fixed by the previous patch.

Unconditionally setting _BrowseProperty was causing a bug in the
installer for League of Legends whereby pressing the Cancel button
prompted the user to select a folder.

Signed-off-by: Zebediah Figura <z.figura12 at gmail.com>
---
 dlls/msi/package.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/dlls/msi/package.c b/dlls/msi/package.c
index 6c24f61..4c44a84 100644
--- a/dlls/msi/package.c
+++ b/dlls/msi/package.c
@@ -746,8 +746,6 @@ static VOID set_installer_properties(MSIPACKAGE *package)
     static const WCHAR szPrintHoodFolder[] = {'P','r','i','n','t','H','o','o','d','F','o','l','d','e','r',0};
     static const WCHAR szRecentFolder[] = {'R','e','c','e','n','t','F','o','l','d','e','r',0};
     static const WCHAR szComputerName[] = {'C','o','m','p','u','t','e','r','N','a','m','e',0};
-    static const WCHAR szBrowseProperty[] = {'_','B','r','o','w','s','e','P','r','o','p','e','r','t','y',0};
-    static const WCHAR szInstallDir[] = {'I','N','S','T','A','L','L','D','I','R',0};
 
     /*
      * Other things that probably should be set:
@@ -1019,7 +1017,6 @@ static VOID set_installer_properties(MSIPACKAGE *package)
             msi_free( computername );
         }
     }
-    msi_set_property( package->db, szBrowseProperty, szInstallDir, -1 );
 }
 
 static MSIPACKAGE *msi_alloc_package( void )
-- 
2.7.4




More information about the wine-patches mailing list