[PATCH] msi: Avoid uninitialized pointer access on error path (Coverity)

Nikolay Sivov nsivov at codeweavers.com
Mon Jul 24 09:35:22 CDT 2017


Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

The issue is that msi_free() is called on uninitialized pointer.

 dlls/msi/format.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/dlls/msi/format.c b/dlls/msi/format.c
index 4297fbc740..108b28dcc9 100644
--- a/dlls/msi/format.c
+++ b/dlls/msi/format.c
@@ -840,7 +840,7 @@ static DWORD deformat_string_internal(MSIPACKAGE *package, LPCWSTR ptr,
 UINT MSI_FormatRecordW( MSIPACKAGE* package, MSIRECORD* record, LPWSTR buffer,
                         LPDWORD size )
 {
-    WCHAR *format, *deformated;
+    WCHAR *format, *deformated = NULL;
     UINT rc = ERROR_INVALID_PARAMETER;
     DWORD len;
     MSIRECORD *record_deformated;
-- 
2.13.2




More information about the wine-patches mailing list