[PATCH 4/5] regedit: Remove un-necessary parser state assignment if we are returning to the same state
Hugh McMaster
hugh.mcmaster at outlook.com
Fri Jun 30 08:42:43 CDT 2017
Signed-off-by: Hugh McMaster <hugh.mcmaster at outlook.com>
---
programs/regedit/regproc.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/programs/regedit/regproc.c b/programs/regedit/regproc.c
index d6ea5c7ea3..e5a4f741e8 100644
--- a/programs/regedit/regproc.c
+++ b/programs/regedit/regproc.c
@@ -532,7 +532,7 @@ static WCHAR *parse_win31_line_state(struct parser *parser, WCHAR *pos)
return NULL;
if (strncmpW(line, hkcr, ARRAY_SIZE(hkcr)))
- goto invalid;
+ return line;
/* get key name */
while (line[key_end] && !isspaceW(line[key_end])) key_end++;
@@ -548,7 +548,7 @@ static WCHAR *parse_win31_line_state(struct parser *parser, WCHAR *pos)
if (open_key(parser, line) != ERROR_SUCCESS)
{
output_message(STRING_OPEN_KEY_FAILED, line);
- goto invalid;
+ return line;
}
parser->value_name = NULL;
@@ -558,10 +558,6 @@ static WCHAR *parse_win31_line_state(struct parser *parser, WCHAR *pos)
set_state(parser, SET_VALUE);
return value;
-
-invalid:
- set_state(parser, PARSE_WIN31_LINE);
- return line;
}
/* handler for parser LINE_START state */
@@ -589,7 +585,6 @@ static WCHAR *line_start_state(struct parser *parser, WCHAR *pos)
case '\t':
break;
default:
- set_state(parser, LINE_START);
return p;
}
}
--
2.11.0
More information about the wine-patches
mailing list