[PATCH 1/5] d3d11: Downgrade unknown DWORD FIXMEs() to TRACE() messages.

Józef Kucia jkucia at codeweavers.com
Wed Mar 22 03:40:53 CDT 2017


Signed-off-by: Józef Kucia <jkucia at codeweavers.com>
---

These FIXMEs() are generally not useful.

---
 dlls/d3d11/shader.c | 2 +-
 dlls/d3d11/utils.c  | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/dlls/d3d11/shader.c b/dlls/d3d11/shader.c
index ae19eba..547181e 100644
--- a/dlls/d3d11/shader.c
+++ b/dlls/d3d11/shader.c
@@ -183,7 +183,7 @@ HRESULT shader_parse_signature(const char *data, DWORD data_size, struct wined3d
     read_dword(&ptr, &count);
     TRACE("%u elements\n", count);
 
-    skip_dword_unknown(&ptr, 1);
+    skip_dword_unknown(&ptr, 1); /* It seems to always be 0x00000008. */
 
     if (!require_space(ptr - data, count, 6 * sizeof(DWORD), data_size))
     {
diff --git a/dlls/d3d11/utils.c b/dlls/d3d11/utils.c
index 89dbbda..a470fdb 100644
--- a/dlls/d3d11/utils.c
+++ b/dlls/d3d11/utils.c
@@ -727,11 +727,11 @@ void skip_dword_unknown(const char **ptr, unsigned int count)
     unsigned int i;
     DWORD d;
 
-    FIXME("Skipping %u unknown DWORDs:\n", count);
+    TRACE("Skipping %u unknown DWORDs:\n", count);
     for (i = 0; i < count; ++i)
     {
         read_dword(ptr, &d);
-        FIXME("\t0x%08x\n", d);
+        TRACE("\t0x%08x\n", d);
     }
 }
 
@@ -754,10 +754,10 @@ HRESULT parse_dxbc(const char *data, SIZE_T data_size,
         return E_INVALIDARG;
     }
 
-    /* checksum? */
+    TRACE("Ignoring DXBC checksum.\n");
     skip_dword_unknown(&ptr, 4);
 
-    skip_dword_unknown(&ptr, 1);
+    skip_dword_unknown(&ptr, 1); /* It seems to always be 0x00000001. */
 
     read_dword(&ptr, &total_size);
     TRACE("total size: %#x\n", total_size);
-- 
2.10.2




More information about the wine-patches mailing list