[PATCH] wmvcore: Add WMReader stubs.

Jefferson Carpenter jeffersoncarpenter2 at gmail.com
Thu Mar 30 17:30:09 CDT 2017

Do FIXME statements need to print out the passed-in arguments?  Only
outputting the method name, you can still tell what needs to be
implemented.  Also, to output each argument, there are typedefs to
consider, and you have to choose whether to dereference any pointer
arguments, which makes it rather difficult to automate the process.

I could submit just the IDL changes, without the stubs added to
wmvcore_main.c.  Sorry Alistair, they seem to include your additions as

On Thu, Mar 30, 2017 at 8:20 AM, Andrew Eikum <aeikum at codeweavers.com>

> On Thu, Mar 30, 2017 at 08:25:03AM +0000, Alistair Leslie-Hughes wrote:
> > I have a basic patch for adding tests in the works, but I was waiting
> > for my IDL changes to be accepted first.
> >
> > So, If someone wants to review the IDL changes, Since Sebastian has been
> > busy with other stuff.
> >
> > https://source.winehq.org/patches/data/131403
> >
> Okay :) I just noticed one thing:
> > +    HRESULT GetAttributeCountEx(
> > +        [in] WORD stream_num,
> > +        [out] WORD attributes );
> If attributes is an out-param, it should be a pointer, right?
> Andrew
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-patches/attachments/20170330/605f3c2f/attachment.html>

More information about the wine-patches mailing list