[PATCH] xmllite/tests: Fix clang warning

Nikolay Sivov nsivov at codeweavers.com
Sun Nov 5 02:39:53 CST 2017


Reported by Gerald Pfeifer.

Signed-off-by: Nikolay Sivov <nsivov at codeweavers.com>
---

Fixed differently to avoid type casting.

 dlls/xmllite/tests/reader.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/dlls/xmllite/tests/reader.c b/dlls/xmllite/tests/reader.c
index 0f03c3b42e..00337764a6 100644
--- a/dlls/xmllite/tests/reader.c
+++ b/dlls/xmllite/tests/reader.c
@@ -273,7 +273,7 @@ static void test_read_state(IXmlReader *reader, XmlReadState expected,
     state = -1; /* invalid state value */
     IXmlReader_GetProperty(reader, XmlReaderProperty_ReadState, &state);
 
-    if (exp_broken == -1)
+    if (exp_broken == expected)
         broken_state = FALSE;
     else
         broken_state = broken(exp_broken == state);
@@ -282,7 +282,7 @@ static void test_read_state(IXmlReader *reader, XmlReadState expected,
             state_to_str(expected), state_to_str(state));
 }
 
-#define TEST_READER_STATE(reader, state) test_read_state(reader, state, -1, __LINE__)
+#define TEST_READER_STATE(reader, state) test_read_state(reader, state, state, __LINE__)
 #define TEST_READER_STATE2(reader, state, brk) test_read_state(reader, state, brk, __LINE__)
 
 #define reader_value(a,b) _reader_value(__LINE__,a,b)
-- 
2.14.2




More information about the wine-patches mailing list