[PATCH] inetcomm: In SMTPTransport_ParseResponse remove unneeded statement (cppcheck)
Fabian Maurer
dark.shadow4 at web.de
Tue Oct 3 10:37:26 CDT 2017
pszResponse++ doesn't do anything since the variable isn't used anymore.
Also restructured the code to make it shorter.
Found by cppcheck.
Signed-off-by: Fabian Maurer <dark.shadow4 at web.de>
---
dlls/inetcomm/smtptransport.c | 8 +-------
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/dlls/inetcomm/smtptransport.c b/dlls/inetcomm/smtptransport.c
index c88ac9c65c..af11308258 100644
--- a/dlls/inetcomm/smtptransport.c
+++ b/dlls/inetcomm/smtptransport.c
@@ -59,13 +59,7 @@ static HRESULT SMTPTransport_ParseResponse(SMTPTransport *This, char *pszRespons
pResponse->rIxpResult.pszResponse = pszResponse;
pResponse->rIxpResult.dwSocketError = 0;
pResponse->rIxpResult.uiServerError = strtol(pszResponse, &pszResponse, 10);
- if (*pszResponse == '-')
- {
- pResponse->fDone = FALSE;
- pszResponse++;
- }
- else
- pResponse->fDone = TRUE;
+ pResponse->fDone = (*pszResponse != '-');
switch (pResponse->rIxpResult.uiServerError)
{
--
2.14.2
More information about the wine-patches
mailing list