[Tools] testbot: Remove redundant calls to RescheduleJobs().

Francois Gouget fgouget at codeweavers.com
Tue Oct 10 16:56:44 CDT 2017


Modifying a VM's Status field already triggers a rescheduling
($VM->Save() triggers $VM->OnSaved() which calls VMStatusChange() to
notify the Engine's HandleVMStatusChange() which calls ScheduleJobs()).
So there is no need to call RescheduleJobs() right after saving the
VM's new status.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/bin/WineRunBuild.pl    | 1 -
 testbot/bin/WineRunReconfig.pl | 1 -
 testbot/bin/WineRunTask.pl     | 1 -
 3 files changed, 3 deletions(-)

diff --git a/testbot/bin/WineRunBuild.pl b/testbot/bin/WineRunBuild.pl
index 326ac0cb..85fe568c 100755
--- a/testbot/bin/WineRunBuild.pl
+++ b/testbot/bin/WineRunBuild.pl
@@ -241,7 +241,6 @@ sub WrapUpAndExit($;$)
   {
     $VM->Status($NewVMStatus);
     $VM->Save();
-    RescheduleJobs();
   }
 
   my $Result = $VM->Name .": ". $VM->Status ." Status: $Status Failures: ". (defined $TestFailures ? $TestFailures : "unset");
diff --git a/testbot/bin/WineRunReconfig.pl b/testbot/bin/WineRunReconfig.pl
index d8e007d7..b2071cd7 100755
--- a/testbot/bin/WineRunReconfig.pl
+++ b/testbot/bin/WineRunReconfig.pl
@@ -242,7 +242,6 @@ sub WrapUpAndExit($;$)
   {
     $VM->Status($NewVMStatus);
     $VM->Save();
-    RescheduleJobs();
   }
 
   my $Result = $VM->Name .": ". $VM->Status ." Status: $Status Failures: ". (defined $TestFailures ? $TestFailures : "unset");
diff --git a/testbot/bin/WineRunTask.pl b/testbot/bin/WineRunTask.pl
index 618ef8fe..2328b31c 100755
--- a/testbot/bin/WineRunTask.pl
+++ b/testbot/bin/WineRunTask.pl
@@ -270,7 +270,6 @@ sub WrapUpAndExit($;$$)
   {
     $VM->Status($NewVMStatus);
     $VM->Save();
-    RescheduleJobs();
   }
 
   if ($Status eq 'completed' and $Step->Type eq 'suite')
-- 
2.14.2




More information about the wine-patches mailing list