[Tools] testbot: Queued Tasks are not supposed to have a child process.

Francois Gouget fgouget at codeweavers.com
Wed Oct 11 09:17:33 CDT 2017


So just silently unset ChildPid in Task::UpdateStatus() if needed, like 
we do for the tasks in other states that should not have a child 
process. Since they are queued they will get run later on anyway.

Signed-off-by: Francois Gouget <fgouget at codeweavers.com>
---
 testbot/lib/WineTestBot/Tasks.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/testbot/lib/WineTestBot/Tasks.pm b/testbot/lib/WineTestBot/Tasks.pm
index 68438b68..401e2757 100644
--- a/testbot/lib/WineTestBot/Tasks.pm
+++ b/testbot/lib/WineTestBot/Tasks.pm
@@ -158,7 +158,7 @@ sub UpdateStatus($$)
   if (defined $self->ChildPid && !kill(0, $self->ChildPid) && $! == ESRCH)
   {
     $self->ChildPid(undef);
-    if ($Status eq "queued" || $Status eq "running")
+    if ($Status eq "running")
     {
       my ($JobId, $StepNo, $TaskNo) = @{$self->GetMasterKey()};
       my $OldUMask = umask(002);
-- 
2.14.2



More information about the wine-patches mailing list