[PATCH v2 1/3] mshtml: Add a null parameter check in navigate_new_window().

Zebediah Figura zfigura at codeweavers.com
Fri Sep 15 00:34:10 CDT 2017


v2: check in caller instead of do_query_service().
Signed-off-by: Zebediah Figura <zfigura at codeweavers.com>
---
 dlls/mshtml/navigate.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/dlls/mshtml/navigate.c b/dlls/mshtml/navigate.c
index 423d650a8c..06425c3f2b 100644
--- a/dlls/mshtml/navigate.c
+++ b/dlls/mshtml/navigate.c
@@ -2246,6 +2246,12 @@ HRESULT navigate_new_window(HTMLOuterWindow *window, IUri *uri, const WCHAR *nam
     nsChannelBSC *bsc;
     HRESULT hres;
 
+    if (!window->doc_obj->client)
+    {
+        FIXME("no attached client site; cannot query INewWindowManager\n");
+        return E_NOTIMPL;
+    }
+
     hres = do_query_service((IUnknown*)window->doc_obj->client, &SID_SNewWindowManager, &IID_INewWindowManager,
             (void**)&new_window_mgr);
     if(SUCCEEDED(hres)) {
-- 
2.14.1




More information about the wine-patches mailing list