79638: msi: Mark fall-throughs in switch statements
buildbot at kegel.com
buildbot at kegel.com
Thu Oct 6 19:51:45 CDT 2011
This is an experimental automated build and test service.
Please feel free to ignore this email while we work the kinks out.
For more info about this message, see http://wiki.winehq.org/BuildBot
The Buildbot has detected a failed build on builder runtests-default while building Wine.
Full details are available at: http://buildbot.kegel.com/builders/runtests-default/builds/40 (though maybe not for long, as I'm still reinstalling the buildbot periodically while experimenting)
BUILD FAILED: failed git
Errors:
error: patch failed: dlls/msi/automation.c:1510
error: dlls/msi/automation.c: patch does not apply
error: patch failed: dlls/msi/database.c:658
error: dlls/msi/database.c: patch does not apply
-------------- next part --------------
From: Andrew Talbot <andrew.talbot at talbotville.com>
Subject: msi: Mark fall-throughs in switch statements
Message-Id: <201110062229.46566.andrew.talbot at talbotville.com>
Date: Thu, 6 Oct 2011 22:29:46 +0100
Changelog:
msi: Mark fall-throughs in switch statements.
diff --git a/dlls/msi/automation.c b/dlls/msi/automation.c
index 26ed87f..d62c989 100644
--- a/dlls/msi/automation.c
+++ b/dlls/msi/automation.c
@@ -1510,6 +1510,7 @@ static void variant_from_registry_value(VARIANT *pVarResult, DWORD dwType, LPBYT
while (idx >= 0 && !szString[idx]) idx--;
for (; idx >= 0; idx--)
if (!szString[idx]) szString[idx] = '\n';
+ /* fall through */
case REG_SZ:
V_VT(pVarResult) = VT_BSTR;
V_BSTR(pVarResult) = SysAllocStringByteLen((LPCSTR)szString, dwSize);
diff --git a/dlls/msi/database.c b/dlls/msi/database.c
index 3813f30..1f3ab81 100644
--- a/dlls/msi/database.c
+++ b/dlls/msi/database.c
@@ -658,6 +658,7 @@ static LPWSTR msi_build_createsql_columns(LPWSTR *columns_data, LPWSTR *types, D
{
case 'l':
lstrcpyW(extra, type_notnull);
+ /* fall through */
case 'L':
lstrcatW(extra, localizable);
type = type_char;
@@ -665,12 +666,14 @@ static LPWSTR msi_build_createsql_columns(LPWSTR *columns_data, LPWSTR *types, D
break;
case 's':
lstrcpyW(extra, type_notnull);
+ /* fall through */
case 'S':
type = type_char;
sprintfW(size, size_fmt, ptr);
break;
case 'i':
lstrcpyW(extra, type_notnull);
+ /* fall through */
case 'I':
if (len <= 2)
type = type_int;
@@ -685,6 +688,7 @@ static LPWSTR msi_build_createsql_columns(LPWSTR *columns_data, LPWSTR *types, D
break;
case 'v':
lstrcpyW(extra, type_notnull);
+ /* fall through */
case 'V':
type = type_object;
break;
More information about the wine-tests-results
mailing list