Transgaming, Install Shield, and the dead horse

[Gavriel State]

"Geoffrey L. Hausheer" wrote:
> 
> So not to beat a dead horse or anything, but after seeing Gavriel's note
> that InstallShield was working in the latest Transgaming patch (I have no
> need of the Direct3d stuff, but I was not able to find any relevant pattches
> by Andreas on PATCHES), I installed the patch, and tried out installing
> MediaPlayer yet again, and nothing has changed from last time (I.e it hangs
> in and endless loop waiting for something, but I don't know what...my
> attempts at debugging have not led me to any insights).  So where did this
> 'partial fix' from Andreas Mohr come from, and why couldn't I find it on
> patches(I looked at the patch, but didn't see anything that looked
> immediately relevant)?  Is it still likely that this is due to the
> interprocess-communication, or should I be looking for something else?  Is
> the supposed fix in the patch only relevant to games?

Unfortunately, it's not a cure-all for InstallShield issues.  Some of the
most recent InstallShield versions are still broken (ones that rely on 
their 'ikernel.exe' stuff and cross-process communication through OLE 
TypeLibs). Sorry for getting ahead of ourselves with the announcement.

Andreas' patch is this bit below: it hasn't made it into WineHQ yet since
Alexandre wants more extensive testing first.   

Index: wine/windows/win.c
diff -u wine/windows/win.c:1.1.1.12 wine/windows/win.c:1.6
--- wine/windows/win.c:1.1.1.12 Fri Jan 26 14:16:01 2001
+++ wine/windows/win.c  Fri Jan 26 14:32:35 2001
@@ -2030,9 +2030,12 @@
                                                type, WIN_PROC_WINDOW );
                goto end;
        case GWL_STYLE:
-               style.styleOld = wndPtr->dwStyle;
-               newval &= ~(WS_CHILD);  /* this bit can't be changed this way */
-               style.styleNew = newval | (style.styleOld & (WS_CHILD));
+               /* FIXME: this part originally prevented you from modifying
+                * WS_VISIBLE and WS_CHILD flags.
+                * However at least Win95 allows modification for both
+                * Win16 and Win32. Was this a limitation for < Win95 only ? */
+                style.styleOld = wndPtr->dwStyle;
+                style.styleNew = newval; 
 
                if (wndPtr->flags & WIN_ISWIN32)
                        SendMessageA(hwnd,WM_STYLECHANGING,GWL_STYLE,(LPARAM)&style);

-Gav

-- 
Gavriel State, CEO
TransGaming Technologies Inc.
http://www.transgaming.com
gav at transgaming.com