[Bug 12401] Support junction points, i.e. DeviceIoCtl(FSCTL_SET_REPARSE_POINT/FSCTL_GET_REPARSE_POINT)

[wine-bugs at winehq.org]

http://bugs.winehq.org/show_bug.cgi?id=12401

--- Comment #19 from André H. <nerv at dawncrow.de> 2012-06-19 13:15:22 CDT ---
(In reply to comment #18)
> Created attachment 40600 [details]
> Patch series to add support for junction points [v2]
> 
> I've updated the patch series for junction points to address Andre's comments.

1-3 and 5 are much better now.

4:
 * do we really want to advertise junction point support for every fs? [1]
6:
 * more tests, please. 95 test line changes are suspicious regarding
junctionpoints
 * test special cases not only create, read, delete per ioctl, but use e.g.
DeleteFile() to delete the link and see what happens, delete the target and see
what happens, ...
 * sticking to only "c:" could be avoided. GetTempFileName doesn't even ensure
to get a tempfile on c:, so rather do GetTempFileName first and check the
volume from the returned path.
 * all these skip() makes me nervous, maybe some more win_skip() when
appropriate. Further i think they can be reduced.
 * maybe you can manage to split the tests, so that you can add creation tests
to patch 1, reading tests to patch 2, ...

Anyway, you did a good job.

[1]
http://superuser.com/questions/429034/how-do-i-create-a-symlink-on-ntfs-from-linux
(and on fat(every kind of), hpfs, ... we also can't symlink, to be fair no one
should run wine on them, but maybe the data is stored there, not sure)

-- 
Configure bugmail: http://bugs.winehq.org/userprefs.cgi?tab=email
Do not reply to this email, post in Bugzilla using the
above URL to reply.
------- You are receiving this mail because: -------
You are watching all bug changes.