Implement SelectPalette and RealizePalette in mfdrv
Dmitry Timoshkov
dmitry at baikal.ru
Thu Feb 6 09:18:19 CST 2003
<Warren_Baird at cimmetry.com> wrote:
> diff -ur clean/wine/objects/palette.c wine/objects/palette.c
> --- clean/wine/objects/palette.c Wed Jan 29 15:31:13 2003
> +++ wine/objects/palette.c Fri Jan 31 12:47:21 2003
> @@ -674,6 +674,7 @@
> }
> if (!(dc = DC_GetDCPtr( hdc ))) return 0;
> prev = dc->hPalette;
> + if (dc->funcs->pSelectPalette) hpal = dc->funcs->pSelectPalette(
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
here hpal is zeroed out.
> dc->physDev, hpal, FALSE );
> dc->hPalette = hpal;
^^^^^^^^^^^^^^^^^^^
1. The above code chunk always sets dc->hPalette to zero in the case of
metafile dc.
2. It seems that most of your all patches are wrapped by your mailer.
3. Some of your patches use C++ comments.
4. Some of your patches use a C++ style of declaring variables in the
arbitrary place of the function.
Please fix all of the above and resend the affected patches. Thanks.
--
Dmitry.
More information about the wine-devel
mailing list