Clean-up of scroll.c (1/4)

[Alexandre Julliard]

"Andrew M. Johnston" <johnstonam at logica.com> writes:

> -    return (info->fMask & SIF_ALL) != 0;
> +
> +    return (info->fMask & SIF_ALL);

[...]

> -    if (lpMin) *lpMin = infoPtr->minVal;
> -    if (lpMax) *lpMax = infoPtr->maxVal;
> -    return TRUE;
> +    TRACE("hwnd=%p nBar=%d lpMin=%p lpMax=%p\n", hwnd, nBar, lpMin, lpMax);
> +    
> +    if (lpMin) *lpMin = infoPtr ? infoPtr->minVal : 0;
> +    if (lpMax) *lpMax = infoPtr ? infoPtr->maxVal : 0;
> +    
> +    return (BOOL)infoPtr;

Please don't do this kind of gratuitous changes. Boolean functions
should return TRUE or FALSE, unless you have evidence that Windows
does it differently. Yes, I know any non-zero value is true in C, but
you can't rely on every Windows programmer to get it right.

-- 
Alexandre Julliard
julliard at winehq.com