version change broke InstMsiA.exe

[James Hawkins]

Hi,

The following patch broke InstMsiA.exe:

Modified files:
       dlls/ntdll     : version.c

Log message:
       Ivan Leo Puoti <puoti at inwind.it>
       Better EXE version check in VERSION_GetLinkedDllVersion.

Patch: http://cvs.winehq.org/patch.py?id=14894

Here is +ver:

trace:ver:VERSION_Init getting version from
L"AppDefaults\\InstMsiA.exe\\Version"
trace:ver:VERSION_Init getting default version
trace:ver:VERSION_GetLinkedDllVersion L"InstMsiA.exe": 07.00/05.01/05.01/04.00
trace:ver:VERSION_GetLinkedDllVersion 07.00/05.01/05.01/04.00
trace:ver:RtlGetVersion <-- Windows XP (L"Service Pack 2")
....
trace:ver:RtlGetVersion <-- Windows XP (L"Service Pack 2")
trace:ver:VERSION_Init getting version from L"AppDefaults\\msiinst.exe\\Version"
trace:ver:VERSION_Init getting default version
trace:ver:VERSION_GetLinkedDllVersion L"msiinst.exe": 07.00/05.01/05.01/04.00
trace:ver:VERSION_GetLinkedDllVersion 07.00/05.01/05.01/04.00
trace:ver:RtlGetVersion <-- Windows XP (L"Service Pack 2")
...

Before the change GetLinkedDllVersion recognized InstMsiA.exe as
win98, but now it's XP SP2.  I'm not sure how to change this test to
make it work because both InstMsiA.exe (win9x version) and
InstMsiW.exe (nt/xp version) return
07.00/05.01/05.01/04.00 for GetLinkedDllVersion.  One solution is to
just use the config file and specify win98, but since we are moving
away from the config file I think it would be worth figuring out why
this isn't working yet.

-- 
James Hawkins