USER32: result of ScrollBar functions review (4th try)
Alexandre Julliard
julliard at winehq.org
Sat Jan 8 12:44:07 CST 2005
Vitaly Lipatov <lav at etersoft.ru> writes:
> @@ -1728,12 +1821,15 @@
> SCROLLINFO info;
>
> TRACE("hwnd=%p nBar=%d min=%d max=%d, bRedraw=%d\n", hwnd, nBar, minVal, maxVal, bRedraw);
> -
> +
> info.cbSize = sizeof(info);
> info.fMask = SIF_RANGE;
> info.nMin = minVal;
> info.nMax = maxVal;
> SetScrollInfo( hwnd, nBar, &info, bRedraw );
> + if (nBar == SB_CTL)
> + FIXME("needs to send SMB_SETRANGE when SB_CTL\n");
> + //return SendMessageW(hwnd, SBM_SETRANGE, (WPARAM)0, (LPARAM)0);
> return TRUE;
There's no reason to add a FIXME, calling SetScrollInfo is perfectly
fine and it's what Windows does too, we even have a test for it.
Also please send separate changes as separate patches, especially when
you are renaming functions which causes a lot of changes all over and
makes it hard to see what else is changing.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list