loader: Mark the stack as executable if possible.

[Peter Beutner]

Marcus Meissner schrieb:
> On Wed, Nov 15, 2006 at 06:09:40PM +0000, L. Rahyen wrote:
>>> So for fixing some _broken_ applications this patch unconditionally
>>> disables nx protection for every application running under wine. Seems like
>>> a bad tradeoff imo. (Though I don't know how widespread these kind of
>>> broken applications are. But there are definitly applications out there
>>> which don't need this.)
>> 	Most of Windows applications will not work. Especialy games. Yes there some 
>> applications that work but this is mostly small applications without complex 
>> GUI. Some example are Proxomitron (this is a proxy) and mdict (simple 9KB 
>> program with graphical interface). But most users use Wine for Games and for 
>> applications with complex GUI (complex GUI = complex application in most 
>> cases). Just try 10-20 popular games and 10-20 popular applications - most of 
>> them will crash without McCormack's patch or with noexec=on. Even if real 
>> problem is because of broken PE header this doesn't matter - we must emulate 
>> typical Windows behavior in such case (at least by default).
> 
> This is incorrect, even with NX most applications will work. Only those with
> broken PE headers like above will not.
There are still those apps which allocate some memory( read-writeable only), 
extract/decrypt some code into that memory and then try to run it.
These won't work either.