programs/winefontcfg: Add winefontcfg

Dmitry Timoshkov dmitry at codeweavers.com
Wed Jul 11 23:12:37 CDT 2007


"Dan Kegel" <dank at kegel.com> wrote:

> I think those static function prototypes in winefontcfg.h should not be there.
> .h files are for things shared between files;
> your prototypes were probably put there to
> avoid compiler errors.  Better to put them in the .c file
> if they're  not used by multiple files.

Or even better completely avoid forward declarations by properly
arranging internal functions. winefontcfg.h is not needed at all.

Some other comments: INT_PTR is not appropriate return type for window
procs, global variables should be made static.

-- 
Dmitry.



More information about the wine-devel mailing list