[PATCH] usp10: Use passed hdc instead of cached one for ScriptTextOut with test to check

Hans Leidekker hans at it.vu.nl
Tue Apr 29 04:12:08 CDT 2008


On Tuesday 29 April 2008 06:15:23 Guy Albertelli wrote:

> Application does most of the Script... calls under one hdc then deletes it
>  prior to calling the ScriptTextOut with the original hdc.

Out of curiosity, which app is that? What are the symptoms? I tested
your patch on some of the apps I know that use usp10 (TomTom HOME, Firefox,
PAF5) and didn't see any obvious regressions.

> -    if (!ExtTextOutW(get_cache_hdc(psc), x, y, fuOptions, lprc, pwGlyphs, cGlyphs, NULL))
> +    if (!ExtTextOutW(hdc, x, y, fuOptions, lprc, pwGlyphs, cGlyphs, NULL))

You should also get rid of the calls to get_script_cache and
un/select_cached_font; they are redundant now.

 -Hans



More information about the wine-devel mailing list