winhttp: Implement some more options.

Jacek Caban jacek at codeweavers.com
Wed Sep 3 09:37:48 CDT 2008


Hi Hans,

Hans Leidekker wrote:
>  
> +static BOOL session_set_option( object_header_t *hdr, DWORD option, LPVOID buffer, DWORD buflen )
> +{
> +    if (hdr->type != WINHTTP_HANDLE_TYPE_SESSION)
> +    {
> +        release_object( hdr );
> +        set_last_error( ERROR_WINHTTP_INCORRECT_HANDLE_TYPE );
> +        return FALSE;
> +    

release_object call looks wrong here. Also, if you use vtbls properly, 
you shouldn't need to check the type here.


Jacek



More information about the wine-devel mailing list