PrintDlgEx [2/7]: Add basic dialog.

Michael Stefaniuc mstefani at redhat.com
Thu Sep 18 02:58:15 CDT 2008


Hello Gal,

there is no point in adding new resources in English to the other
languages rc files. If a resource doesn't exist Win32 will automatically
fail over to use the en_US version.

Actually its even detrimental to add the new resources as:
a.) http://pf128.krakow.sdi.tpnet.pl/wine-transl/ cannot show those
resources as untranslated.
b.) The copied English resources have a tendency to bit-rot.
c.) The patch is smaller and offers the exact same functionality.

You need to only amend existing resources in the language files that
have that resource. To make it easy the Wine wrc supports the
--verify-translation switch. Just take the wrc command that make is
running in that directory and append --verify-translation to it. Do that
before and after you applied your patch. If you see additional lines
popping up that start with "DIFF" or "ERR" your patch breaks the
translations and you'll have to check what resource you need to amend.

Gal Topper wrote:
>  dlls/comdlg32/cdlg_Bg.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Cs.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Da.rc |   38 +++++++
>  dlls/comdlg32/cdlg_De.rc |   38 +++++++
>  dlls/comdlg32/cdlg_El.rc |   38 +++++++
>  dlls/comdlg32/cdlg_En.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Eo.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Es.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Fi.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Fr.rc |   38 +++++++
>  dlls/comdlg32/cdlg_It.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Ja.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Ko.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Nl.rc |   38 +++++++
>  dlls/comdlg32/cdlg_No.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Pl.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Pt.rc |   85 +++++++++++++++
>  dlls/comdlg32/cdlg_Ro.rc |   40 +++++++
>  dlls/comdlg32/cdlg_Ru.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Si.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Sk.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Sv.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Th.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Tr.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Uk.rc |   38 +++++++
>  dlls/comdlg32/cdlg_Zh.rc |   38 +++++++
>  dlls/comdlg32/printdlg.c |  269 +++++++++++++++++++++++++++++++++++++++++++++-
>  dlls/comdlg32/printdlg.h |   20 ++++-
>  28 files changed, 1323 insertions(+), 3 deletions(-)

bye
	michael



More information about the wine-devel mailing list