Very long printernames and test failures

Paul Vriens paul.vriens.wine at gmail.com
Sun Dec 6 12:28:53 CST 2009


Hi Detlef,

Some test failures are shown on boxes with long printernames, for example:

http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/vista_test-on-vista/winspool.drv:info.html
http://test.winehq.org/data/17b7ee13fb55e872902be3156610e583e4cd324b/win7_153/winspool.drv:info.html

And indeed if I create a local printer with a very long name the cutoff 
is one bigger than what the test is currently doing.

The attached patch fixes that.

I don't think this is enough though. Our implementation cuts of at '-1' 
from the looks of it. The best test would probably to add a printer in 
the tests and check for the size of the name in the strcut but I don't 
know how easy/intrusive that is.

Any thoughts?

-- 
Cheers,

Paul.
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: patch
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20091206/cbac1201/attachment.txt>


More information about the wine-devel mailing list