Need help on couple of patches

[Dmitry Timoshkov]

"Igor Tarasov" <tarasov.igor at gmail.com> wrote:

> Now I don't get it. Looked through listview tests and there are not
> even one mouse-related test. And my patch could be tested by just
> sending HDN_ITEMCLICKW to listview control. And capturing the response
> notifications.

Then just do it that way.

> But the code is:
> 
> static LRESULT LISTVIEW_HeaderNotification(LISTVIEW_INFO *infoPtr,
> const NMHEADERW *lpnmh)
> {
>    ...
>    switch (lpnmh->hdr.code)
>    {
>        ...
>        case HDN_ITEMCLICKW:
>        case HDN_ITEMCLICKA:
>        {
>            ...
>            notify_forward_header(infoPtr, lpnmh);
>        }
>        break;
> 
> Is that really should be tested for being executed, by simulating
> mouse click? Or I just don't understand something?

It's up to you how to execute the requested functionality.
If that's absolutely necessary it's not too hard to send
WM_LBUTTONDOWN/WM_LBUTTONUP to the control.

-- 
Dmitry.