[3\4] d3d9: Partially implement GetAdapterDisplayModeEx

Chris Robinson chris.kcat at gmail.com
Tue Jul 20 16:51:09 CDT 2010


On Tuesday, July 20, 2010 2:28:44 pm Louis Lenders wrote:
> +    TRACE("iface %p, adapter %u, mode %p.\n", iface, adapter, mode);
> +    TRACE("iface %p, adapter %u, mode %p, rotation %p\n", iface, adapter,
> mode, rotation);

This doesn't look right. You probably only need the second TRACE statement, 
there.

It also looks like adapterinfo is being leaked. Any reason you HeapAlloc one 
to pass in, instead of passing a pointer to a stack object? Eg:

struct wined3d_adapter_info_ex adapterinfo;
...
hr = IWineD3D_GetAdapterDisplayMode(This->WineD3D, adapter, &m, &adapterinfo);



More information about the wine-devel mailing list