shell32/tests: add tests for the parser of SHELLEXECUTEINFO.lpFile [try 4]

[Ilya Basin]

Hello. I'll wait for your comments for some time before trying to send
"try 5".

JL> I think you're still confused by the prohibition against using
JL> GetVersion.  Your changes follow the letter of that edict, but not the
JL> spirit:
lol, it's almost the same thing US customs inspector told a person
I know, when she started to travel too often.

JL> What you want to do instead is to call shell_execute in any case
JL> (unless doing so would crash.)  You'll want to check rc on succeeding
JL> versions of Windows/Wine with ok, and mark it as broken elsewhere.
JL> E.g.,
JL>   rc = shell_execute(NULL, fileA, NULL, NULL);
JL>   ok((rc==expected || rc>32 && expected>32) || broken(rc == whatever
JL> busted versions of Windows return), "expected ...");
Thanks, I'll try to follow your recommendation.
However, the drawback of using broken() is when running on wine, an
.exe compiled with visual studio won't show test failures.
Only "make test" in tests directory will notice these failures.

JL> Also, those TEST_LPFILE_PARSED_OK macros are ugly, and hard to fix if
JL> one place has a certain behavior, while another has different
JL> behavior.  Just use ok directly wherever you're using the macro.
Not convinced. What you say is good for reading, but not editing.
If someone wants to change behavior , the other person
defined in a macro, but only in one place, he can jast as simple
copy-paste the definition and edit it.
In any case, it's a free country (c).
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: 0001-shell32-tests-add-tests-for-the-parser-of-SHELLEXECUTE.txt
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20100306/615c9496/attachment-0001.txt>