[PATCH 4/5] [Kernel32, Server]: fixed a couple of bugs when reading bare console input with overlapped operations

Alexandre Julliard julliard at winehq.org
Mon Nov 29 06:31:10 CST 2010


Eric Pouech <eric.pouech at orange.fr> writes:

> @@ -3011,6 +3014,7 @@ BOOL CONSOLE_Init(RTL_USER_PROCESS_PARAMETERS *params)
>              /* reply->event shouldn't be created by server */
>          }
>          SERVER_END_REQ;
> +        fcntl( 0, F_SETFL, O_NONBLOCK );

I don't think that's a good idea, the calling process may not expect
that. Also using overlapped I/O seems overkill considering that you
already have a Unix fd.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list