include: Remove 'l' modifier from numeric constants in d3d9caps.h
mstefani at redhat.com
Wed Oct 26 05:35:28 CDT 2011
Chris Robinson wrote:
> On Wednesday, October 26, 2011 12:17:22 PM Michael Stefaniuc wrote:
>> Hello Jacek!
>> Jacek Caban wrote:
>>> mingw-w64 project imports some of our headers, including most of d3d
>>> headers. They would probably prefer to keep them with 'l' modifier since
>>> that's the right thing to do. Given that it's mostly harmless for Wine,
>>> could we please consider not changing it?
>> Well ... the the dinput.h was a real change were Wine was affected.
>> But the change should be mostly harmless for mingw-w64 as long == int on
>> Win32 and Win64.
> The compiler does still complain about types even if the type is the same
> size. Such as when using printf formatting (%x = int, #lx = long; GCC
> complains if the type doesn't match, even if it's the same size). Also I could
Right, one of the reasons we do this change for Wine.
> imagine some C++ function overrides tripping up with the int/long difference.
If you use the Wine headers this should actually fix it as it brings the
numeric constants in line with the types as LONG == int in Wine.
More information about the wine-devel