[2/2] shell32: Be safe against removal of entries in SHChangeNotify

Piotr Caban piotr.caban at gmail.com
Tue Sep 20 08:42:26 CDT 2011


Hi,

On 09/19/11 20:52, André Hentschel wrote:
> @@ -325,7 +325,7 @@ void WINAPI SHChangeNotify(LONG wEventId, UINT uFlags, LPCVOID dwItem1, LPCVOID
>       EnterCriticalSection(&SHELL32_ChangenotifyCS);
>
>       /* loop through the list */
> -    LIST_FOR_EACH_ENTRY( ptr,&notifications, NOTIFICATIONLIST, entry )
> +    LIST_FOR_EACH_ENTRY_SAFE( ptr, next,&notifications, NOTIFICATIONLIST, entry )
The function should not call SendMessage inside critical section.

Cheers,
Piotr



More information about the wine-devel mailing list