[6/6] d3drm: Implement GetParent

Nikolay Sivov bunglehead at gmail.com
Mon Jan 9 16:02:51 CST 2012


On 1/9/2012 23:42, André Hentschel wrote:
> Am 08.01.2012 20:02, schrieb Nikolay Sivov:
>> On 1/8/2012 20:47, André Hentschel wrote:
>>> ---
>>>    dlls/d3drm/frame.c       |   11 +++++++----
>>>    dlls/d3drm/tests/d3drm.c |   16 ++++++++--------
>>>    2 files changed, 15 insertions(+), 12 deletions(-)
>>>
>>> diff --git a/dlls/d3drm/frame.c b/dlls/d3drm/frame.c
>>> index 212f7dd..b72700c 100644
>>> --- a/dlls/d3drm/frame.c
>>> +++ b/dlls/d3drm/frame.c
>>> @@ -33,6 +33,7 @@ typedef struct {
>>>        IDirect3DRMFrame2 IDirect3DRMFrame2_iface;
>>>        IDirect3DRMFrame3 IDirect3DRMFrame3_iface;
>>>        LONG ref;
>>> +    LPVOID parent;
>>>    } IDirect3DRMFrameImpl;
>> Parent is store as another frame interface pointer, right? Why void* here?
> Didn't read that at first time. I wanted to access parent as LPDIRECT3DRMFRAME, LPDIRECT3DRMFRAME2 and maybe LPDIRECT3DRMFRAME3
You mean access IDirect3DRMFrameImpl through that pointer? It's better 
to avoid that if possible, I mean a preferred way is to use interface 
methods when interface pointer is supplied by a caller instead of 
relying on internal implementation. It's not always possible of course, 
but still.




More information about the wine-devel mailing list