[PATCH 1/4] mshtml: Moved IStream::Read calls to separated function

Dmitry Timoshkov dmitry at baikal.ru
Fri Jul 27 04:05:51 CDT 2012


Jacek Caban <jacek at codeweavers.com> wrote:

> +static HRESULT read_stream(BSCallback *This, IStream *stream, void *buf, DWORD size, DWORD *ret_size)
> +{
> +    DWORD read_size = 0;
> +    HRESULT hres;
> +
> +    hres = IStream_Read(stream, buf, size, &read_size);
> +    This->readed += (*ret_size = read_size);
> +    return hres;
> +}

Using 'ret_size' directly in the IStream_Read call would look more
natural IMHO, like:
hres = IStream_Read(stream, buf, size, ret_size);
This->readed += *ret_size;

-- 
Dmitry.



More information about the wine-devel mailing list