urlmon: Compile tests with -D__WINESRC__.

Alexandre Julliard julliard at winehq.org
Mon Nov 11 07:03:40 CST 2013


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> Alexandre Julliard <julliard at winehq.org> wrote:
>
>> >> >> > Please don't use lstrlenA in the tests.
>> >> >> 
>> >> >> Dmitry, could you please elaborate more on that?
>> >> >
>> >> > It hides the bugs.
>> >> 
>> >> Not with -D__WINESRC__.
>> >
>> > PSDK or mingw headers don't have an idea about __WINESRC__.
>> 
>> Yes but it can't possibly hide bugs, since all tests will be built and
>> tested with the Wine headers too.
>
> I don't follow, it wouldn't hide bugs only if the tests would be built and
> tested *without* the Wine headers too.

What hides bugs is the exception handler in lstrlen. When the tests are
built with Wine headers, there's no exception handler, so it will crash
and the bug will be caught. The only way a bug could remain hidden is if
no one ever builds that test with Wine headers, which is not realistic.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list