[PATCH 1/5] wined3d: Create a proper texture for the software cursor.

Stefan Dösinger stefandoesinger at gmail.com
Mon Nov 18 07:42:47 CST 2013


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2013-11-18 14:22, schrieb Henri Verbeet:
> Mostly because the existing code used WINED3D_POOL_SCRATCH.
I think this code predates any pool checks in blits, and I believe I
used it because EVE Online passed a WINED3D_POOL_SCRATCH surface to
SetCursorProperties and I just copied this behavior.

> It's also what we use for the logo texture, although arguably that
> could be changed as well. WINED3D_POOL_DEFAULT could work, but it
> would require some extra code to destroy the texture on resets.
I think D3DPOOL_MANAGED should just work.

The reason for the surface on the stack added in 65e5ed60 were cyclic
references between surface and device. I think your patch should be
safe in this regard, but I cannot remember why I thought this approach
wouldn't work back in 2006. Did you consider reference cycles when you
wrote your patch? (The logo surface would be affected by the same
problem.)

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJSihlXAAoJEN0/YqbEcdMwk7cP/i0EpkxGAuCgu/7NHVitxWfy
wwnJCnATfXvJMpsM8N8vGJmcadVhl/m3R7QrK6pBxnkhRkuV77DcCvGYbjFxgfBk
d14jJ5pi32irJAT9OUqoRm7nLC1yY2h38KBZlKXow6o4tRt257Osl981way1hswf
r+quKzNtRuQq5qOR/mq8PzkMrcpMmH0Mm/kADCPjPy5fti/VP6/TxOdkGXSjKDm+
uLc7KPxrdIChT5zzRxg3/88PF1sFksoGnvbxqkoKS3iBTcgS865ZDJklmoyIY/zi
JURqa1/8WRizPYO57yxiifHWkSAejFli7URhF+9Nfjv/ngN1VKgu1XuNxH91R2Tv
vx7KKsvsxiYT0NeNhJw/Yy2U3icbU4McneLVUgSGHn6n70kHo7cZF0XSf6Yp1ozJ
PBB9/yAoUVmUJpGAD93qvnNYPfOrLYPlEbv8OL7d3q0ukpjEBM0AlWdW+T0Px0K+
IK01nWxzzMvRjDpUzYmEsOsKPHnpUvGclP4X1/dOoL4u99YKWoeoi3eDXLhT5CFR
b0VMTpIuuZeJO4hiALftPBH88u6rdjALoLa0BIkPvLcD4/o2OQ+7JgOFJ7i4tAce
EfG669YAUGjzJyTBA+hNxHGpBEasNIMQbFgiRdqyRFtoT6nE/H/21DOornBOwk0O
uAbtMBNOtxR/2HM089eW
=DydU
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list