Fixing up the code style

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-02-13 14:57, schrieb Jacek Caban:
> Well, another solution is to be less picky about coding style
> during reviews. You gave me a perfect example just after writing
> this mail:
> 
> http://www.winehq.org/pipermail/wine-devel/2014-February/102864.html
>
>  I'm mostly talking about the second comment. Seriously? Is that 
> worth a resend?
Maybe, or maybe not. The basic issue still stands. New contributors
will look at the existing code, and if its inconsistent how are they
supposed to write code that's consistent in itself. That's not a
question of pickiness but approach to the problem.

Take a look at e.g.
http://www.winehq.org/pipermail/wine-patches/2014-February/130297.html
. It has plenty of inconsistencies, and none of them are the
contributor's fault. Should we ignore that as well? If so, should we
allow the codebase to look like that?

My impression was that the answers to that were no and no, with the
idea that the problem will be fixed by unifying the style together
with other, functional changes. That way we end up with picky reviews
and IMO that approach is bad.

Martin, Michael or Sebastian: If you are reading this thread maybe you
can share your thoughts from the point of view of someone who isn't a
long-term contributor.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJS/NWiAAoJEN0/YqbEcdMw0WAP/3pxrgE8BZhrFZtdVipd10Yv
8gwg9uB9fzWJfrcjiBoXiCUn7UHLKs3pmsAp/2VtwPVLC1mgAnNOH3uvKW94oz/3
w2jymggEuRr9Xu8CCAu/fcJmg3sLhu/OGM2edwmos5QS82R5oNs+92FStlw2aACM
PMAV3Qgt1CLFFRIi/AH5bFHUqb3finphKWl4B2H50s3E3RSxJYkYN2Y8GsdqXdi7
xl/g/QbMWhICddjqbiLreSrRt1I92KIYizCpjK2yhWRlrpk/eDB1CjspsxS1j1+l
H2dTLEq7+tL4I3tjoBQs9T/Inz5sgeor6satQqxJYzOaRr0GJrG7egzBId9pAmmP
YpOxYr06MRmebDmVjRf388kL2bVZy6IA0dE7EM1dX0X6qJL8pTwjM6FfME10+ijO
WVb1scOsTsS8SRSy2LvVmCo0UlUb2/EtADJct91i2nxI5Bdoge3131BBxOr6QIFg
4mywxT1+xPkrJAwVa8vs3R6gQZiNNIZ5Fe9/mP8LkgKTVCB5qMO12UY5a8QRacsf
FnPpbVbI4hXxbkftqOTrFGUNUruEEJYLm2jX6fInZ6Jsx86Ix9Lwa1jtGujJIUkH
Iki9EvZLX0Qh+BlI+0+A7csbypftbkT+b8WQG7NwXpIX8j38yrtJaFqEInCoHzDM
KzyT7fE5o2u5QW3G/WtX
=O2Cu
-----END PGP SIGNATURE-----