[PATCH 8/9] d3dx9: Add test for 'cmp' preshader opcode.

[Paul Gofman]

On 05/11/2017 06:32 PM, Matteo Bruni wrote:
> 2017-05-11 17:08 GMT+02:00 Paul Gofman <gofmanp at gmail.com>:
> Well, yes, I mean creating by hand an effect blob with the specific
> instruction encodings you're currently testing in
> test_effect_preshader_ops(). You might make a separate preshader /
> state for each instruction or not (or anything in between), whatever
> is easier.
>
So do you suggest to make the complete effect blob which is not 
generated by compiler, with all the tested operations built in there? If 
this is the case I am afraid it will make any change / adding 
instruction test or input parameters combination a nightmare, unless I 
am going to make a compiler for that, and much less readable than it is 
now with the table of tested instructions. Or do you mean just different 
(small) compiled effect blob with "placeholder" instructions to set the 
opcodes, pretty much as it is done now, just in a dedicated smaller 
blob? Then the code will be pretty much the same to what it is now 
though, just different effect blob. Or am I misunderstanding you entirely?