[PATCH 2/5] wined3d: Ignore invalid input signature entries in shader_get_registers_used().

Henri Verbeet hverbeet at gmail.com
Wed Feb 9 12:43:19 CST 2022


On Wed, 9 Feb 2022 at 16:50, Matteo Bruni <mbruni at codeweavers.com> wrote:
> @@ -1802,7 +1802,7 @@ static HRESULT shader_get_registers_used(struct wined3d_shader *shader, DWORD co
>                  if (input_signature->elements[i].register_idx >= ARRAY_SIZE(shader->u.vs.attributes))
>                  {
>                      WARN("Invalid input signature register index %u.\n", input_signature->elements[i].register_idx);
> -                    return WINED3DERR_INVALIDCALL;
> +                    continue;
>                  }
I don't know what specifically happens with the application mentioned
in the commit message, but note that the WARN above can be somewhat
misleading. vs_4_1 and vs_5_0 support 32 input registers, but
wined3d's MAX_ATTRIBS (used to size the "attributes" array above) is
defined as 16.



More information about the wine-devel mailing list