[LostWages] Update Janitorial Page (should be up to date for now)
Tony Lambregts
tony_lambregts at telusplanet.net
Mon Jan 3 20:41:45 CST 2005
- Jacek Caban got rid of some W->A calls.
There is still one W->A call in wine/dlls/shlwapi/ordnial.c This is what the
code says for SHCreateWorkerWindowW.
/* If our OS is natively ASCII, use the ASCII version */
if (!(GetVersion() & 0x80000000)) /* NT */
return SHCreateWorkerWindowA(wndProc, hWndParent, dwExStyle, dwStyle,
hMenu, z);
Also in StrRetToStrW there is a similar situation.
switch (lpStrRet->uType)
{
case STRRET_WSTR:
hRet = SHStrDupW(lpStrRet->u.pOleStr, ppszName);
CoTaskMemFree(lpStrRet->u.pOleStr);
break;
case STRRET_CSTR:
hRet = SHStrDupA(lpStrRet->u.cStr, ppszName);
break;
I have marked both as invalid
Change Log: Update janitorial page.
Files changed: /templates/en/janitorial.template
-------------- next part --------------
Index: templates/en/janitorial.template
===================================================================
RCS file: /home/wine/lostwages/templates/en/janitorial.template,v
retrieving revision 1.50
diff -u -r1.50 janitorial.template
--- templates/en/janitorial.template 3 Jan 2005 23:35:35 -0000 1.50
+++ templates/en/janitorial.template 4 Jan 2005 02:40:08 -0000
@@ -138,13 +138,13 @@
<li>dlls/shell32/shellole.c: shell32: DragQueryFileW: illegal call to DragQueryFileA
<li>dlls/shell32/systray.c: shell32: Shell_NotifyIconW: illegal call to Shell_NotifyIconA
<li class=committed>dlls/shlwapi/ordinal.c: shlwapi: SHStringFromGUIDW: illegal call to SHStringFromGUIDA
- <li>dlls/shlwapi/ordinal.c: shlwapi: SHCreateWorkerWindowW: illegal call to SHCreateWorkerWindowA
+ <li class=invalid>dlls/shlwapi/ordinal.c: shlwapi: SHCreateWorkerWindowW: illegal call to SHCreateWorkerWindowA
<li class=committed>dlls/shlwapi/ordinal.c: shlwapi: SHCreateWorkerWindowW: illegal call to LoadCursorA
<li class=committed>dlls/shlwapi/ordinal.c: shlwapi: SHCreateWorkerWindowW: illegal call to SetWindowLongA
- <li>dlls/shlwapi/string.c: shlwapi: StrCmpLogicalW: illegal call to SHLWAPI_ChrCmpHelperA
- <li>dlls/shlwapi/string.c: shlwapi: StrFormatByteSizeW: illegal call to StrFormatByteSize64A
- <li>dlls/shlwapi/string.c: shlwapi: StrRetToStrW: illegal call to SHStrDupA
- <li>dlls/shlwapi/string.c: shlwapi: StrRStrIW: illegal call to ChrCmpIA
+ <li class=committed>dlls/shlwapi/string.c: shlwapi: StrCmpLogicalW: illegal call to SHLWAPI_ChrCmpHelperA
+ <li class=committed>dlls/shlwapi/string.c: shlwapi: StrFormatByteSizeW: illegal call to StrFormatByteSize64A
+ <li class=invalid>dlls/shlwapi/string.c: shlwapi: StrRetToStrW: illegal call to SHStrDupA
+ <li class=committed>dlls/shlwapi/string.c: shlwapi: StrRStrIW: illegal call to ChrCmpIA
<li>dlls/version/install.c: version: VerInstallFileW: illegal call to VerInstallFileA
<li>dlls/wininet/internet.c: wininet: InternetCheckConnectionW: illegal call to InternetCheckConnectionA
<li>dlls/winmm/driver.c: winmm: OpenDriverW: illegal call to OpenDriverA
More information about the wine-patches
mailing list